#186: Avoid multiple saves when handling name and address protection #187
Conversation
ds-bellcom
added
the
Incl. in the next release
| // Only manipulate element on submission create form. | ||
| if (!$webformSubmission->isCompleted()) { | ||
| if ($cprLookupResult && $cprLookupResult->isNameAddressProtected()) { | ||
| // @todo What is this used for? |
There was a problem hiding this comment.
This comes from this requirement in BKDK-550:
https://os2web.atlassian.net/browse/BKDK-550?focusedCommentId=64745
The address field needed to have a hint that it's protected/beskyttet
I see that this key is most likely custom one: #info_message i also don't see any theme using it. For me, it's same to delete this line
If that answers the questions, please remove todo comment from the code 🙂
There was a problem hiding this comment.
@stankut, do you suggest removing
$element['#info_message'] = 'adresse beskyttelse';
(along with the todo comment)?
There was a problem hiding this comment.
yes, that was my idea. Please do that while you're on it, i see no effect of this line anymore
modules/os2forms_nemid/src/Plugin/WebformElement/NemidAddress.php
Outdated
Show resolved
Hide resolved
| // Only manipulate element on submission create form. | ||
| if (!$webformSubmission->isCompleted()) { | ||
| if ($cprLookupResult && $cprLookupResult->isNameAddressProtected()) { | ||
| // @todo What is this used for? |
There was a problem hiding this comment.
@stankut, do you suggest removing
$element['#info_message'] = 'adresse beskyttelse';
(along with the todo comment)?
…ess-protected-submission
…ess-protected-submission
rimi-itk
deleted the
feature/avoid-double-save-on-name-and-address-protected-submission
branch
4 participants
Handles #186 by ensuring submissions are not saved twice.
Important
This PR is currently aimed at the master branch since the develop branch is many features ahead and a potential patch version should be without these features.